Fixed bugs in relative_TT_residuals_plotter#215
Fixed bugs in relative_TT_residuals_plotter#215outdoorpet wants to merge 9 commits intoGeoscienceAustralia:developfrom
Conversation
…' column when reading picks ensemble file into Pandas data frame. Fixed bug where script will crash if there are no common events (parameter df_plot = None). So just need to catch the df_plot = None case.
zhang01GA
left a comment
zhang01GA
left a comment
There was a problem hiding this comment.
Thanks Ashby for the PR. It looks all good to me except a bit of concern on the import changed to relative path: what if this script is run outside the seismic/gps_corrections/ directory? and in the scenario when seismic package is installed by a "pip install ".
zhang01GA
left a comment
zhang01GA
left a comment
There was a problem hiding this comment.
merge is approved. thanks.
Hi Fei, yes I realised afterwards that the script was meant to be called from the top level directory. Disregard that import modification. Cheers |
2 participants
Modified imports to suit relative import. Fixed bug in missing 'phase' column when reading picks ensemble file into Pandas data frame. Fixed bug where script will crash if there are no common events (parameter df_plot = None). So just need to catch the df_plot = None case.